MIME-Version: 1.0
In-Reply-To: <53B55FA6.5080801@cogentembedded.com>
References: <1404393762-858019-1-git-send-email-manuel.lauss@gmail.com>
 <1404393762-858019-6-git-send-email-manuel.lauss@gmail.com> <53B55FA6.5080801@cogentembedded.com>
From: Manuel Lauss <manuel.lauss@gmail.com>
Date: Thu, 3 Jul 2014 19:19:52 +0200
Message-ID: <CAOLZvyFit=cuXHjtx=v2oOBAdj9yj1nwODzBQ+3EP7MpongZoA@mail.gmail.com>
Subject: Re: [RFC PATCH v2 05/11] MIPS: Alchemy: pci: use clk framework to
 enable PCI clock
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
        Mike Turquette <mturquette@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org

Hi Sergei,

On Thu, Jul 3, 2014 at 3:50 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>> --- a/arch/mips/pci/pci-alchemy.c
>> +++ b/arch/mips/pci/pci-alchemy.c
>> @@ -394,11 +396,24 @@ static int alchemy_pci_probe(struct platform_device
>> *pdev)

>> +       ret = clk_prepare_enable(c);
>> +       if (ret) {
>> +               dev_err(&pdev->dev, "cannot enable PCI clock\n");
>> +               clk_put(c);
>> +               goto out2;
>
>
>    Isn't it simpler to add one more label before clk_put() at end of
> function?

Yes, I have changed it locally.


Thank you!
       Manuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/