Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757871AbaGCTyK (ORCPT ); Thu, 3 Jul 2014 15:54:10 -0400 Received: from Mycroft.westnet.com ([216.187.52.7]:39799 "EHLO mycroft.westnet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbaGCTyI (ORCPT ); Thu, 3 Jul 2014 15:54:08 -0400 X-Greylist: delayed 622 seconds by postgrey-1.27 at vger.kernel.org; Thu, 03 Jul 2014 15:54:08 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21429.45664.255694.85431@quad.stoffel.home> Date: Thu, 3 Jul 2014 15:43:28 -0400 From: "John Stoffel" To: Linus Torvalds Cc: Raghavendra K T , Andrew Morton , Fengguang Wu , David Cohen , Al Viro , Damien Ramonda , Jan Kara , David Rientjes , Nishanth Aravamudan , linux-mm , Linux Kernel Mailing List Subject: Re: [PATCH] mm readahead: Fix sys_readahead breakage by reverting 2MB limit (bug 79111) In-Reply-To: References: <1404392547-11648-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <53B59CB5.9060004@linux.vnet.ibm.com> X-Mailer: VM 8.2.0b under 23.4.1 (x86_64-pc-linux-gnu) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Linus" == Linus Torvalds writes: Linus> On Thu, Jul 3, 2014 at 11:22 AM, Linus Torvalds Linus> wrote: >> >> So the bugzilla entry worries me a bit - we definitely do not want to >> regress in case somebody really relied on timing - but without more >> specific information I still think the real bug is just in the >> man-page. Linus> Side note: the 2MB limit may be too small. 2M is peanuts on modern Linus> machines, even for fairly slow IO, and there are lots of files (like Linus> glibc etc) that people might want to read-ahead during boot. We Linus> already do bigger read-ahead if people just do "read()" system calls. Linus> So I could certainly imagine that we should increase it. Linus> I do *not* think we should bow down to insane man-pages that have Linus> always been wrong, though, and I don't think we should increase it to Linus> "let's just read-ahead a whole ISO image" kind of sizes.. This is one of those perenial questions of how to tune this. I agree we should increase the number, but shouldn't it be based on both the amount of memory in the machine, number of devices (or is it all just one big pool?) and the speed of the actual device doing readahead? Doesn't make sense to do 32mb of readahead on a USB 1.1 thumb drive or even a CDROM. But maybe it does for USB3 thumb drives? John -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/