Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087AbaGDH1z (ORCPT ); Fri, 4 Jul 2014 03:27:55 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:28624 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750988AbaGDH1x (ORCPT ); Fri, 4 Jul 2014 03:27:53 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 99.127.230.128 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18pP8hsSALM3JhuhMbjreCp Date: Fri, 4 Jul 2014 00:27:53 -0700 From: Tony Lindgren To: Pascal Huerst Cc: santosh.shilimkar@ti.com, khilman@deeprootsystems.com, linus.walleij@linaro.org, gnurou@gmail.com, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Mack Subject: Re: gpio-omap: wakeup mask Message-ID: <20140704072752.GC28884@atomide.com> References: <53B3F687.5050502@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53B3F687.5050502@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pascal Huerst [140702 05:12]: > Hi everyone, > > we have a device with an am335x and are using some gpios on bank0 to > wake up the device from suspend to ram. > > We have some user buttons which are configured in the devicetree as > gpio-keys and one power-key which should wake up the device: > > &buttons { > power { > label = "Power"; > gpios = <&gpio0 6 1>; > linux,code = <116>; > gpio-key,wakeup; > }; > > one { > label = "One"; > gpios = <&gpio0 11 1>; > linux,code = <2>; > }; > > : : : > } > > The problem is, that the device wakes up on any trigger on bank 0. No > matter which button was pressed. "gpio-key,wakeup" seems not to have any > influence. > > Now, if I comment the following lines out in drivers/gpio/gpio-omap.c : > set_gpio_trigger(...). > > 321 > 322 if (likely(!(bank->non_wakeup_gpios & gpio_bit))) { > 323 _gpio_rmw(base, bank->regs->wkup_en, gpio_bit, trigger != 0); > 324 bank->context.wake_en = > 325 readl_relaxed(bank->base + bank->regs->wkup_en); > 326 } > 327 > > Everything works as expected. But I don't really understand why? Is this > a bug, or does this break something else I have not discovered yet? The GPIO wake-up events are working from off-idle for omap3 the last time I checked, so sounds like this is some am335x related issue. What does your bank->context.wake_en mask get set to with this code? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/