Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758632AbaGDQRm (ORCPT ); Fri, 4 Jul 2014 12:17:42 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:35236 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752202AbaGDQRk (ORCPT ); Fri, 4 Jul 2014 12:17:40 -0400 MIME-Version: 1.0 In-Reply-To: References: <1404351693-5588-1-git-send-email-xerofoify@gmail.com> Date: Fri, 4 Jul 2014 18:17:38 +0200 X-Google-Sender-Auth: d7mjStWeiYg5QLf_9RlP8Iwxw8o Message-ID: Subject: Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h From: Geert Uytterhoeven To: Nick Krause Cc: Finn Thain , Sam Creasey , linux-m68k , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 4, 2014 at 6:10 PM, Nick Krause wrote: > Very well then seems I should resend this patch removing the define > line as it seems to have no use > in this file. Indeed. Thanks in advance! FYI, the last user of _KERNPG_TABLE was removed in 2.5.18. > Cheers Nick > > On Fri, Jul 4, 2014 at 2:19 AM, Finn Thain wrote: >> >> On Fri, 4 Jul 2014, Nick Krause wrote: >> >>> What are these two lines for them another compile issue? >> >> I don't see why those two lines are important. >> >>> >> -/* FIXME - when we get this compiling */ >>> >> /* erm, now that it's compiling, what do we do with it? */ >>> >> #define _KERNPG_TABLE 0 >> >> Presumably it is the third line that the "FIXME" refers to. >> >> I didn't write this code, but obviously it isn't supposed to be read as >> >> /* FIXME - this comment needs to be deleted */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/