Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758902AbaGDQb3 (ORCPT ); Fri, 4 Jul 2014 12:31:29 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:40883 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753285AbaGDQb0 (ORCPT ); Fri, 4 Jul 2014 12:31:26 -0400 Date: Fri, 4 Jul 2014 17:31:19 +0100 From: Mark Rutland To: Daniel Jeong Cc: Jingoo Han , Bryan Wu , Lee Jones , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , "grant.likely@linaro.org" , Rob Herring , Randy Dunlap , Daniel Jeong , "linux-kernel@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [RFC v4 2/2] backlight: device tree: add new tps611xx backlight binding Message-ID: <20140704163119.GB7106@leverpostej> References: <1404367277-12003-1-git-send-email-gshark.jeong@gmail.com> <1404367277-12003-3-git-send-email-gshark.jeong@gmail.com> <20140703090447.GC29837@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +- rfa-enable: enable request for acknowledge. > > +  If RFA is enabled, the data byte includes the RFA bit and device will > wait > > +  and check acknowledge from device. > > You didn't answer my question as to why this should be in the DT. > > > According to the RFA enable, the easy scale pin works differently. > This value should be set before the first data transfer. Sure, things works differently if this is set. That I understood. What I haven't heard is a rationale as to why this configuration option shuold be in the DT. Can I enable this on all implementations, or not? When would I enable this and when would I not? The property reads like a switch to turn a feature on, rather than the description of the presence of a feature. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/