Message-ID: <1404493440.6384.28.camel@joe-AO725>
Subject: Re: [PATCH] checkpatch: Emit a warning on file add/move/delete
From: Joe Perches <joe@perches.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Date: Fri, 04 Jul 2014 10:04:00 -0700
In-Reply-To: <20140704151128.GC20758@bark>
References: <1404434816.6384.5.camel@joe-AO725>
	 <20140704151128.GC20758@bark>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Fri, 2014-07-04 at 16:11 +0100, Andy Whitcroft wrote:
> On Thu, Jul 03, 2014 at 05:46:56PM -0700, Joe Perches wrote:
> > Whenever files are added, moved, or deleted, the
> > MAINTAINERS file patterns can be out of sync or
> > outdated.
> > 
> > To try to keep MAINTAINERS more up-to-date, add a
> > one-time warning whenever a patch does any of those.
[]
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> > +# Check for added, moved or deleted files
> > +		if (!$reported_maintainer_file && !$in_commit_log &&
> > +		    ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||
> > +		     $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
> > +		     ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
> > +		      (defined($1) || defined($2))))) {
> > +			$reported_maintainer_file = 1;
> > +			WARN("FILE_PATH_CHANGES",
> > +			     "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
> > +		}
> > +
[]
> That seems like a sensible plan.  Sometime we might try and work out if
> any entries are affected or needed.
> 
> I think you are checking against the git ways of mentioning this only,

Yes, I believe so.

> don't know if there is any milage in checking the dates which also
> convey add/remove info via datea at the epoch.

I don't remember what that date format looks like.
Got an example?

Maybe there's value in checking the diff file header
for /dev/null

Something like:

--- t.c	2014-04-11 10:57:07.767131132 -0700
+++ /dev/null	2014-06-30 13:19:01.524210166 -0700

or

--- /dev/null	2014-06-30 13:19:01.524210166 -0700
+++ t.c	2014-04-11 10:57:07.767131132 -0700

Is there some other form?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/