Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760194AbaGDVWd (ORCPT ); Fri, 4 Jul 2014 17:22:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60473 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753582AbaGDVWc (ORCPT ); Fri, 4 Jul 2014 17:22:32 -0400 Date: Fri, 4 Jul 2014 23:22:29 +0200 (CEST) From: Jiri Kosina To: Olaf Hering cc: Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3.12 13/72] floppy: bail out in open() if drive is not responding to block0 read In-Reply-To: <20140703101233.GA28675@aepfle.de> Message-ID: References: <20140703101233.GA28675@aepfle.de> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Jul 2014, Olaf Hering wrote: > > From: Jiri Kosina > > > commit 7b7b68bba5ef23734c35ffb0d8d82079ed604d33 upstream. > > > +static void floppy_rb0_cb(struct bio *bio, int err) > > { > > - complete((struct completion *)bio->bi_private); > > + struct rb0_cbdata *cbdata = (struct rb0_cbdata *)bio->bi_private; > > + int drive = cbdata->drive; > > + > > + if (err) { > > + pr_info("floppy: error %d while reading block 0", err); > > This change lacks a newline... Fixed by 1c65df3d7 in Linus' tree. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/