Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760331AbaGDXqS (ORCPT ); Fri, 4 Jul 2014 19:46:18 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:63607 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753012AbaGDXqQ (ORCPT ); Fri, 4 Jul 2014 19:46:16 -0400 MIME-Version: 1.0 In-Reply-To: <53B72780.4000302@suse.cz> References: <1402652395-28779-1-git-send-email-mmarek@suse.cz> <539AC82B.4070505@suse.cz> <53B72780.4000302@suse.cz> From: Andy Lutomirski Date: Fri, 4 Jul 2014 16:45:54 -0700 Message-ID: Subject: Re: [PATCH] kbuild: Do not run modules_install and install in paralel To: Michal Marek Cc: "H. Peter Anvin" , X86 ML , "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 4, 2014 at 3:15 PM, Michal Marek wrote: > Dne 13.6.2014 19:29, Andy Lutomirski napsal(a): >> On Fri, Jun 13, 2014 at 2:45 AM, Michal Marek wrote: >>> Dne 13.6.2014 11:39, Michal Marek napsal(a): >>>> Based on a x86-only patch by Andy Lutomirski >>>> >>>> With modular kernels, 'make install' is going to need the installed >>>> modules at some point to generate the initramfs. >>>> >>>> Signed-off-by: Michal Marek >>>> --- >>>> Makefile | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Makefile b/Makefile >>>> index 7680d7c..7e5e483 100644 >>>> --- a/Makefile >>>> +++ b/Makefile >>>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >>>> endif >>>> endif >>>> endif >>>> +# install and module_install need also be processed one by one >>>> +ifneq ($(filter install,$(MAKECMDGOALS)),) >>>> + ifneq ($(filter modules_install,$(MAKECMDGOALS)),) >>>> + mixed-targets := 1 >>>> + endif >>>> +endif >>> >>> Note that this version does not enforce the ordering, it just avoids the >>> interleaved execution. It can be added if desired. >> >> Hmm. This will fix 'make modules_install install' but will not fix >> 'make install modules_install'. I don't know how many people would >> type the latter. > > Resuming a thread from last month -- As I said, it does not enforce the > ordering. So it's not as bullet-proof as your patch, but it works on all > architectures. I'm thinking about adding the patch to kbuild.git for > 3.17. But if you want to fix the ordering as well, feel free to change > the __build_one_by_one rule to do this. Sounds good to me. Where's __build_one_by_one? --Andy > > Thanks, > Michal -- Andy Lutomirski AMA Capital Management, LLC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/