Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760662AbaGEFhZ (ORCPT ); Sat, 5 Jul 2014 01:37:25 -0400 Received: from utopia.booyaka.com ([74.50.51.50]:39715 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914AbaGEFhX (ORCPT ); Sat, 5 Jul 2014 01:37:23 -0400 Date: Sat, 5 Jul 2014 05:37:22 +0000 (UTC) From: Paul Walmsley To: Nicholas Krause cc: tony@atomide.com, linux@arm.linux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mach-omap2: Change if statement in omap2_dflt_clk_enable In-Reply-To: <1404507843-3648-1-git-send-email-xerofoify@gmail.com> Message-ID: References: <1404507843-3648-1-git-send-email-xerofoify@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Jul 2014, Nicholas Krause wrote: > This patch changes this function to check for if v is returning value from the > called function. If not it does the else. Furthermore fixes the FIXME message above > if statement for holding INVERT_ENABLE bit when not needing to be checked for > in if statement by just checking for if v is not Null. > > Signed-off-by: Nicholas Krause This patch doesn't make any sense. Neither does the commit message. Please explain exactly what this patch is intended to do in terms of the clock framework or the hardware. - Paul > --- > arch/arm/mach-omap2/clock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c > index 591581a..626363d 100644 > --- a/arch/arm/mach-omap2/clock.c > +++ b/arch/arm/mach-omap2/clock.c > @@ -379,7 +379,7 @@ void omap2_dflt_clk_disable(struct clk_hw *hw) > } > > v = omap2_clk_readl(clk, clk->enable_reg); > - if (clk->flags & INVERT_ENABLE) > + if (v) > v |= (1 << clk->enable_bit); > else > v &= ~(1 << clk->enable_bit); > -- > 1.9.1 > - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/