From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: "'Tomasz Figa'" <t.figa@samsung.com>, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kgene.kim@samsung.com, linux@arm.linux.org.uk, vikas.sajjan@samsung.com,
        joshi@samsung.com, naushad@samsung.com, thomas.ab@samsung.com,
        chow.kim@samsung.com
References: <1403705032-14835-1-git-send-email-pankaj.dubey@samsung.com>
 <1403705032-14835-6-git-send-email-pankaj.dubey@samsung.com>
 <53B19B42.1040006@samsung.com>
In-reply-to: <53B19B42.1040006@samsung.com>
Subject: RE: [PATCH v5 5/5] ARM: EXYNOS: Move PMU specific definitions from
 common.h
Date: Sat, 05 Jul 2014 12:40:45 +0530
Message-id: <001f01cf9820$3f0ee570$bd2cb050$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: AQK9JhWRh3pvFez7a+k3zuvbSuvV7QFYwQqgAkt3hiuZmNJHwA==
Content-language: en-us
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org

Hi Tomasz,

On Monday, June 30, 2014 Tomasz Figa wrote:
> Hi Pankaj,
> 
> On 25.06.2014 16:03, Pankaj Dubey wrote:
> > This patch moves PMU specific definitions into a new file as
> > exynos-pmu.h.
> > This will help in reducing dependency of common.h in pmu.c.
> >
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> > ---
> >  arch/arm/mach-exynos/common.h     |   17 -----------------
> >  arch/arm/mach-exynos/exynos-pmu.h |   31
> +++++++++++++++++++++++++++++++
> >  arch/arm/mach-exynos/pm.c         |    1 +
> >  arch/arm/mach-exynos/pmu.c        |    2 +-
> >  4 files changed, 33 insertions(+), 18 deletions(-)  create mode
> > 100644 arch/arm/mach-exynos/exynos-pmu.h
> >
> > diff --git a/arch/arm/mach-exynos/common.h
> > b/arch/arm/mach-exynos/common.h index 296c6e1..0326ca2 100644
> > --- a/arch/arm/mach-exynos/common.h
> > +++ b/arch/arm/mach-exynos/common.h
> > @@ -135,23 +135,6 @@ extern struct smp_operations exynos_smp_ops;
> >
> >  extern void exynos_cpu_die(unsigned int cpu);
> >
> > -/* PMU(Power Management Unit) support */
> > -
> > -#define PMU_TABLE_END	(-1U)
> > -
> > -enum sys_powerdown {
> > -	SYS_AFTR,
> > -	SYS_LPA,
> > -	SYS_SLEEP,
> > -	NUM_SYS_POWERDOWN,
> > -};
> > -
> > -struct exynos_pmu_conf {
> > -	unsigned int offset;
> > -	unsigned int val[NUM_SYS_POWERDOWN];
> > -};
> 
> While at it, I'd say this struct could be moved to pmu.c, along with the
> PMU_TABLE_END macro as they are both private to this file.
> 

OK, I will update this.

> Best regards,
> Tomasz

Thanks,
Pankaj Dubey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/