Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbaGEOE0 (ORCPT ); Sat, 5 Jul 2014 10:04:26 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:33158 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbaGEOEY (ORCPT ); Sat, 5 Jul 2014 10:04:24 -0400 MIME-Version: 1.0 In-Reply-To: <1404562393-18641-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1404562393-18641-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Sat, 5 Jul 2014 16:04:22 +0200 X-Google-Sender-Auth: 8gaY8xUmXRd5qBM7Gq9Or1hpYtM Message-ID: Subject: Re: [PATCH] video: fbdev: amifb.c: Cleaning up variable that is never used From: Geert Uytterhoeven To: Rickard Strandqvist Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rickard Strandqvist , Jingoo Han , Daniel Vetter , Joe Perches , Sachin Kamat , Linux Fbdev development list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 5, 2014 at 2:13 PM, Rickard Strandqvist wrote: > From: Rickard Strandqvist > > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist Acked-by: Geert Uytterhoeven > --- a/drivers/video/fbdev/amifb.c > +++ b/drivers/video/fbdev/amifb.c > @@ -1124,7 +1124,6 @@ static int ami_decode_var(struct fb_var_screeninfo *var, struct amifb_par *par, > { > u_short clk_shift, line_shift; > u_long maxfetchstop, fstrt, fsize, fconst, xres_n, yres_n; > - u_int htotal, vtotal; These became unused by commit 3161986224a3faa8ccca3e665b7404d81e7ee3cf Author: Geert Uytterhoeven Date: Wed Dec 13 00:35:54 2006 -0800 [PATCH] fbdev: remove references to non-existent fbmon_valid_timings() Remove references to non-existent fbmon_valid_timings() Signed-off-by: Geert Uytterhoeven Cc: James Simmons Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/