Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754873AbaGEOmB (ORCPT ); Sat, 5 Jul 2014 10:42:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19517 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752945AbaGEOl7 (ORCPT ); Sat, 5 Jul 2014 10:41:59 -0400 Date: Sat, 5 Jul 2014 10:41:09 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Rickard Strandqvist cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rickard Strandqvist , Jingoo Han , Daniel Vetter , Randy Dunlap , Dan Carpenter , Sachin Kamat , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: aty: atyfb_base.c: Cleaning up variable that is never used In-Reply-To: <1404562522-18911-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Message-ID: References: <1404562522-18911-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Jul 2014, Rickard Strandqvist wrote: > From: Rickard Strandqvist > > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist Acked-by: Mikulas Patocka > --- > drivers/video/fbdev/aty/atyfb_base.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c > index c3d0074..46188a4 100644 > --- a/drivers/video/fbdev/aty/atyfb_base.c > +++ b/drivers/video/fbdev/aty/atyfb_base.c > @@ -3088,7 +3088,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info, > if (dp == of_console_device) { > struct fb_var_screeninfo *var = &default_var; > unsigned int N, P, Q, M, T, R; > - u32 v_total, h_total; > struct crtc crtc; > u8 pll_regs[16]; > u8 clock_cntl; > @@ -3104,9 +3103,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info, > crtc.gen_cntl = aty_ld_le32(CRTC_GEN_CNTL, par); > aty_crtc_to_var(&crtc, var); > > - h_total = var->xres + var->right_margin + var->hsync_len + var->left_margin; > - v_total = var->yres + var->lower_margin + var->vsync_len + var->upper_margin; > - > /* > * Read the PLL to figure actual Refresh Rate. > */ > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/