Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755066AbaGERjw (ORCPT ); Sat, 5 Jul 2014 13:39:52 -0400 Received: from eddie.linux-mips.org ([78.24.191.182]:60209 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbaGERjv (ORCPT ); Sat, 5 Jul 2014 13:39:51 -0400 Date: Sat, 5 Jul 2014 18:39:49 +0100 (BST) From: "Maciej W. Rozycki" To: Joe Perches cc: Grant Likely , David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] declance: Fix 64-bit compilation warnings In-Reply-To: <1404576420.6384.41.camel@joe-AO725> Message-ID: References: <20140702.182807.1245632778216212860.davem@davemloft.net> <1404356734.14741.18.camel@joe-AO725> <1404364565.14741.26.camel@joe-AO725> <1404368746.14741.36.camel@joe-AO725> <1404576420.6384.41.camel@joe-AO725> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Jul 2014, Joe Perches wrote: > > One question though, does either of you or anybody else know why we're > > inconsistent about this 0x prefixing of virtual addresses vs physical > > addresses? Specifically %p vs e.g. %pad. > > I think it's a mistake and I agree. > > I submitted a patch to remove the prefix from %pad. > > https://lkml.org/lkml/2014/3/21/333 Great! Your proposal looks good to me in principle, however you need to factor in SPECIAL having been set by `#' somehow as `number' will respect it. I suggest using the same field width calculation that `pointer' uses for `default_width' (sans the type used with `sizeof' of course, that is). Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/