Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755625AbaGERwV (ORCPT ); Sat, 5 Jul 2014 13:52:21 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:55478 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754309AbaGERwT (ORCPT ); Sat, 5 Jul 2014 13:52:19 -0400 Date: Sat, 5 Jul 2014 11:52:16 -0600 From: Bjorn Helgaas To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Ryan Desfosses , linux-pci@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs_remove Message-ID: <20140705175216.GE26618@google.com> References: <1403948683-10410-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403948683-10410-1-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 28, 2014 at 11:44:43AM +0200, Fabian Frederick wrote: > Fix checkpatch warning: > "WARNING: debugfs_remove(NULL) is safe this check is probably not required" > > Cc: Bjorn Helgaas > Cc: Ryan Desfosses > Cc: linux-pci@vger.kernel.org > Signed-off-by: Fabian Frederick Applied to pci/hotplug for v3.17, thanks! > --- > drivers/pci/hotplug/cpqphp_sysfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c > index 4a392c4..d81648f 100644 > --- a/drivers/pci/hotplug/cpqphp_sysfs.c > +++ b/drivers/pci/hotplug/cpqphp_sysfs.c > @@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl) > > void cpqhp_remove_debugfs_files(struct controller *ctrl) > { > - if (ctrl->dentry) > - debugfs_remove(ctrl->dentry); > + debugfs_remove(ctrl->dentry); > ctrl->dentry = NULL; > } > > -- > 1.8.4.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/