Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932645AbaGETLK (ORCPT ); Sat, 5 Jul 2014 15:11:10 -0400 Received: from arrakis.dune.hu ([78.24.191.176]:53537 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932084AbaGETLI (ORCPT ); Sat, 5 Jul 2014 15:11:08 -0400 MIME-Version: 1.0 In-Reply-To: <1404584812-12377-1-git-send-email-emilgoode@gmail.com> References: <1404584812-12377-1-git-send-email-emilgoode@gmail.com> From: Jonas Gorski Date: Sat, 5 Jul 2014 21:10:44 +0200 Message-ID: Subject: Re: [PATCH v2] MIPS: Fix incorrect NULL check in local_flush_tlb_page() To: Emil Goode Cc: Ralf Baechle , Paul Gortmaker , John Crispin , MIPS Mailing List , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 5, 2014 at 8:26 PM, Emil Goode wrote: > We check that the struct vm_area_struct pointer vma is NULL and then > dereference it a few lines below. The intent must have been to make sure > that vma is not NULL and then to check the value from cpu_context() for > the condition to be true. > > Signed-off-by: Emil Goode > --- > > v2: Updated the commit message with a better explanation. > > arch/mips/mm/tlb-r3k.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c > index d657493..6546758 100644 > --- a/arch/mips/mm/tlb-r3k.c > +++ b/arch/mips/mm/tlb-r3k.c > @@ -158,7 +158,7 @@ void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long page) > { > int cpu = smp_processor_id(); > > - if (!vma || cpu_context(cpu, vma->vm_mm) != 0) { > + if (vma && cpu_context(cpu, vma->vm_mm) != 0) { Sorry for replying "too late", but grepping through the kernel code I fail to find any caller that does not dereference vma before calling (local)flush_tlb_page(). Also both tlb-4k and tlb-8k assume vma cannot be NULL, so I would say it is safe to assume vma is never NULL, and the NULL check can be removed completely. Also it looks like this "bug" was there since at least 2.6.12, and never seem to have bitten anyone. Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/