Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932701AbaGEUZz (ORCPT ); Sat, 5 Jul 2014 16:25:55 -0400 Received: from eddie.linux-mips.org ([78.24.191.182]:60523 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753409AbaGEUZy (ORCPT ); Sat, 5 Jul 2014 16:25:54 -0400 Date: Sat, 5 Jul 2014 21:25:52 +0100 (BST) From: "Maciej W. Rozycki" To: Joe Perches cc: Grant Likely , David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] declance: Fix 64-bit compilation warnings In-Reply-To: <1404585099.6384.53.camel@joe-AO725> Message-ID: References: <20140702.182807.1245632778216212860.davem@davemloft.net> <1404356734.14741.18.camel@joe-AO725> <1404364565.14741.26.camel@joe-AO725> <1404368746.14741.36.camel@joe-AO725> <1404576420.6384.41.camel@joe-AO725> <1404583739.6384.51.camel@joe-AO725> <1404585099.6384.53.camel@joe-AO725> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Jul 2014, Joe Perches wrote: > > > I don't think %#p is valid so it > > > shouldn't have been set by #. > > > > Huh? As recently as last Wednesday you pointed me at the specific commit > > from Grant that made it valid (GCC format complaints aside). > > Those gcc complaints are precisely the thing > that makes it invalid. So enforce that in code then, clear the SPECIAL flag where appropriate and do not try to handle it in one place while leaving other ones to behave randomly (i.e. a supposedly fixed field width varies depending on the two uppermost digits). Please note that it's only your proposed change that introduces that randomness, right now code does what's supposed and documented to, except a bit inconsistently. > I believe you're tilting at windmills. > > Hey, it works sometimes. Knock yourself out. I pointed out an inconsistency with the intent to propose a fix once a consensus have been reached, one way or another. And I think shifting the inconsistency to a different place, which is what your proposal does, isn't really a complete solution, although I do recognise the improvement. Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/