Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751652AbaGFPgB (ORCPT ); Sun, 6 Jul 2014 11:36:01 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:56302 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751280AbaGFPf7 (ORCPT ); Sun, 6 Jul 2014 11:35:59 -0400 Date: Sun, 6 Jul 2014 16:35:43 +0100 From: Russell King - ARM Linux To: pawandeep oza Cc: akpm@linux-foundation.org, holt@sgi.com, mingo@kernel.org, sboyd@codeaurora.org, k.khlebnikov@samsung.com, u.kleine-koenig@pengutronix.de, Nicolas Pitre , linux-arm-kernel@lists.infradead.or, linux-kernel@vger.kernel.org Subject: Re: [PATCH] machine_power_off: not only local_irq_disable but also do disable preemption Message-ID: <20140706153542.GU21766@n2100.arm.linux.org.uk> References: <20140705181015.GQ21766@n2100.arm.linux.org.uk> <20140705190105.GR21766@n2100.arm.linux.org.uk> <20140705192634.GT21766@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 06, 2014 at 08:20:36PM +0530, pawandeep oza wrote: > just to add to this, > this scenerio happened on the platform which I am working on, > where interrupts were being re-enabled in rpm_callback path...because the Can you explain how you get to the runtime callback paths from the system reboot/shutdown handlers? In any case, calling the plain _irq (rather than _irqsave) variants of spinlocks when IRQs are already disabled is (another) bug. The plain _irq variants are not permitted when IRQs have been previously disabled. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/