Message-ID: <1404664263.27043.35.camel@joe-AO725>
Subject: Re: [PATCH] thunderbolt: Correct the size argument to devm_kzalloc
From: Joe Perches <joe@perches.com>
To: Himangi Saraogi <himangi774@gmail.com>
Cc: linux-kernel@vger.kernel.org, julia.lawall@lip6.fr
Date: Sun, 06 Jul 2014 09:31:03 -0700
In-Reply-To: <20140706161342.GA6267@himangi-Dell>
References: <20140706161342.GA6267@himangi-Dell>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sun, 2014-07-06 at 21:43 +0530, Himangi Saraogi wrote:
> nhi->rx_rings does not have type as struct tb_ring *, as it is a
> double pointer so the elements of the array should have pointer type,
> not structure type.
[]
> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
[]
> @@ -570,10 +570,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work);
>  
>  	nhi->tx_rings = devm_kzalloc(&pdev->dev,
> -				     nhi->hop_count * sizeof(struct tb_ring),
> +				     nhi->hop_count * sizeof(*nhi->tx_rings),
>  				     GFP_KERNEL);
>  	nhi->rx_rings = devm_kzalloc(&pdev->dev,
> -				     nhi->hop_count * sizeof(struct tb_ring),
> +				     nhi->hop_count * sizeof(*nhi->rx_rings),
>  				     GFP_KERNEL);

It could use devm_kcalloc here too.

btw: are there many false positives with the cocci test?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/