Message-ID: <1404664799.27043.41.camel@joe-AO725>
Subject: Re: [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug
From: Joe Perches <joe@perches.com>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
        micky_ching@realsil.com.cn
Date: Sun, 06 Jul 2014 09:39:59 -0700
In-Reply-To: <CACar8Ln_8+EQGf8z7kNqRPxOcheUuKj5bOg3TJ+xTF_SQFVGQQ@mail.gmail.com>
References: <1404663138-21333-1-git-send-email-fabio.falzoi84@gmail.com>
	 <1404663138-21333-3-git-send-email-fabio.falzoi84@gmail.com>
	 <1404663787.27043.33.camel@joe-AO725>
	 <CACar8Ln_8+EQGf8z7kNqRPxOcheUuKj5bOg3TJ+xTF_SQFVGQQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sun, 2014-07-06 at 18:32 +0200, Fabio Falzoi wrote:
> Have I to fix just the commit message or is this behaviour not suitable?
> In the latter case, could you please suggest a way to fix this?

Hi Fabio.

I think it's not appropriate.
I'd've changed it to something like:

#if DEBUG
#define rtsx_hex_dump(buf, len)						\
	print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE,	\
			     buf, len)
#else
#define rtsx_hex_dump(buf, len)
	do {;} while (0)
#endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/