Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752453AbaGGKCv (ORCPT ); Mon, 7 Jul 2014 06:02:51 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:36250 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751912AbaGGKCt (ORCPT ); Mon, 7 Jul 2014 06:02:49 -0400 MIME-Version: 1.0 In-Reply-To: <1404725217.4501.15.camel@edumazet-glaptop2.roam.corp.google.com> References: <20140705202821.GA25880@mwanda> <1404647816-7564-1-git-send-email-andrey.krieger.utkin@gmail.com> <1404682932.4501.6.camel@edumazet-glaptop2.roam.corp.google.com> <1404723456.4501.14.camel@edumazet-glaptop2.roam.corp.google.com> <1404725217.4501.15.camel@edumazet-glaptop2.roam.corp.google.com> Date: Mon, 7 Jul 2014 13:02:48 +0300 Message-ID: Subject: Re: [PATCH] appletalk: Set skb with destructor From: Andrey Utkin To: Eric Dumazet Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, acme@ghostprotocols.net, netdev@vger.kernel.org, davem@davemloft.net Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-07-07 12:26 GMT+03:00 Eric Dumazet : > Reading again this code, I think all you need is to remove the 2 buggy > lines. > > No need for setup destructors. Reviewing the code again, i find you're right and adding a destructor in that place is stupid, and just not setting skb->sk would make bug disappear, assuming skb->sk is previously NULL. And what about the second case, at ddp.c near line 1650? Is destructor needed here? -- Andrey Utkin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/