Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbaGGKUA (ORCPT ); Mon, 7 Jul 2014 06:20:00 -0400 Received: from mail-oa0-f47.google.com ([209.85.219.47]:41386 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbaGGKT6 (ORCPT ); Mon, 7 Jul 2014 06:19:58 -0400 MIME-Version: 1.0 In-Reply-To: <1402596380-18783-1-git-send-email-eric.ernst@linux.intel.com> References: <1402596380-18783-1-git-send-email-eric.ernst@linux.intel.com> Date: Mon, 7 Jul 2014 12:19:58 +0200 Message-ID: Subject: Re: [PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output From: Linus Walleij To: eric.ernst@linux.intel.com Cc: "linux-kernel@vger.kernel.org" , Mark Gross , Mika Westerberg Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 12, 2014 at 8:06 PM, wrote: > From: Eric Ernst > > For Baytrail, you should never set a GPIO set to direct_irq > to output mode. When direct_irq_en is set for a GPIO, it is > tied directly to an APIC internally, and making the pad output > does not make any sense. Assert a WARN() in the event this happens. > > Signed-off-by: Eric Ernst > Acked-by: Mika Westerberg Patch applied. Sorry for the delay. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/