Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbaGGKV1 (ORCPT ); Mon, 7 Jul 2014 06:21:27 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:5565 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751933AbaGGKVY (ORCPT ); Mon, 7 Jul 2014 06:21:24 -0400 X-IronPort-AV: E=Sophos;i="5.01,617,1400025600"; d="scan'208";a="150403961" Date: Mon, 7 Jul 2014 11:20:39 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Rickard Strandqvist CC: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Stefano Stabellini , Konrad Rzeszutek Wilk , Jingoo Han , Daniel Vetter , , Subject: Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter In-Reply-To: <1404667640-14855-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Message-ID: References: <1404667640-14855-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 6 Jul 2014, Rickard Strandqvist wrote: > Remove assignment of function parameter, that has no effect outside the function > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist Acked-by: Stefano Stabellini > drivers/video/fbdev/xen-fbfront.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c > index 901014b..e1207a1 100644 > --- a/drivers/video/fbdev/xen-fbfront.c > +++ b/drivers/video/fbdev/xen-fbfront.c > @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green, > red = CNVT_TOHW(red, info->var.red.length); > green = CNVT_TOHW(green, info->var.green.length); > blue = CNVT_TOHW(blue, info->var.blue.length); > - transp = CNVT_TOHW(transp, info->var.transp.length); > #undef CNVT_TOHW > > v = (red << info->var.red.offset) | > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/