Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753956AbaGGPYk (ORCPT ); Mon, 7 Jul 2014 11:24:40 -0400 Received: from qmta13.emeryville.ca.mail.comcast.net ([76.96.27.243]:60225 "EHLO qmta13.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbaGGPYi (ORCPT ); Mon, 7 Jul 2014 11:24:38 -0400 Date: Mon, 7 Jul 2014 10:24:35 -0500 (CDT) From: Christoph Lameter To: Vladimir Davydov cc: akpm@linux-foundation.org, mhocko@suse.cz, hannes@cmpxchg.org, glommer@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm 2/8] memcg: keep all children of each root cache on a list In-Reply-To: Message-ID: References: Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Jul 2014, Vladimir Davydov wrote: > diff --git a/mm/slab_common.c b/mm/slab_common.c > index d31c4bacc6a2..95a8f772b0d1 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -294,8 +294,12 @@ struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg, > if (IS_ERR(s)) { > kfree(cache_name); > s = NULL; > + goto out_unlock; > } > > + list_add(&s->memcg_params->siblings, > + &root_cache->memcg_params->children); > + > out_unlock: > mutex_unlock(&slab_mutex); > If there is an error then s is set to NULL. And then the list_add is done dereferencing s? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/