From: Matthew Garrett <matthew.garrett@nebula.com>
To: "bhelgaas@google.com" <bhelgaas@google.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "swarren@nvidia.com" <swarren@nvidia.com>,
        "vidyas@nvidia.com" <vidyas@nvidia.com>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "kthota@nvidia.com" <kthota@nvidia.com>,
        "nagananda.chumbalkar@hp.com" <nagananda.chumbalkar@hp.com>
Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode
Thread-Topic: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode
Thread-Index: AQHPmIMAqTeUUacDIUKmSpwIfKBBfZuR1jCAgALyfQA=
Date: Mon, 7 Jul 2014 16:02:29 +0000
Message-ID: <1404748948.9762.29.camel@x230>
References: <1404198978-26593-1-git-send-email-vidyas@nvidia.com>
	 <20140705185736.GD28871@google.com> <20140705190203.GE28871@google.com>
In-Reply-To: <20140705190203.GE28871@google.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-ID: <51D6E4DAF6B1794AA2E800A287F3ECAE@namprd05.prod.outlook.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit

On Sat, 2014-07-05 at 13:02 -0600, Bjorn Helgaas wrote:
> > Rafael, Matthew, any comments?  We have vacillated on this before and
> > the web is already pretty tangled.
> > 
> > Vidya, can you give more details about the bug fixed by this change?
> > What's the scenario?  Are we resuming and the device is powered up but
> > ASPM isn't enabled?  Maybe you could collect more details in a
> > http://bugzilla.kernel.org report?

I believe that's the case. The proposed change would fix it but isn't
really terribly clean - I think it would be more readable to split this
into multiple functions.

-- 
Matthew Garrett <matthew.garrett@nebula.com>
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?