Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbaGGQTY (ORCPT ); Mon, 7 Jul 2014 12:19:24 -0400 Received: from mail.kernel.org ([198.145.19.201]:42501 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbaGGQTW (ORCPT ); Mon, 7 Jul 2014 12:19:22 -0400 Message-ID: <53BAC90D.6030404@kernel.org> Date: Mon, 07 Jul 2014 17:21:33 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Lars-Peter Clausen , Himangi Saraogi , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org CC: julia.lawall@lip6.fr Subject: Re: [PATCH] staging: iio: Introduce the use of devm_ioremap_resource References: <20140701184413.GA2980@himangi-Dell> <53BA9469.7000600@kernel.org> <53BA9447.6070301@metafoo.de> In-Reply-To: <53BA9447.6070301@metafoo.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/14 13:36, Lars-Peter Clausen wrote: > On 07/07/2014 02:36 PM, Jonathan Cameron wrote: >> On 01/07/14 19:44, Himangi Saraogi wrote: >>> This patch introduces the use of devm_ioremap_resource. It does away >>> with call to request_mem_region and the error checking on >>> platform_get_resource. Also, the calls to free the allocated resources >>> like release_mem_region and iounmap are done away with. The ret variable >>> in the probe function is also eliminated. Also, a bug is fixed as the >>> goto in the error handling of request_mem_region should not have >>> called release_mem_region which releases a resource that has not been >>> allocated. >>> >>> Signed-off-by: Himangi Saraogi >>> Acked-by: Julia Lawall >> Again, looks superficially fine, but I'd like an ack from someone >> at Analog ideally. >> Cc'd Lars > > Acked-by: Lars-Peter Clausen Applied to the togreg branch of iio.git. This will be initially pushed out as testing for the autobuilders to play. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/