Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751794AbaGGR1V (ORCPT ); Mon, 7 Jul 2014 13:27:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51579 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbaGGR1T (ORCPT ); Mon, 7 Jul 2014 13:27:19 -0400 Date: Mon, 7 Jul 2014 10:31:42 -0700 From: Greg Kroah-Hartman To: Linus Walleij Cc: Sascha Silbe , Johan Hovold , Alexandre Courbot , "linux-usb@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] USB: ftdi_sio: add GPIO support Message-ID: <20140707173142.GB8693@kroah.com> References: <1402320115-13171-1-git-send-email-x-linux@infra-silbe.de> <20140613183157.GA24644@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 07, 2014 at 12:44:28PM +0200, Linus Walleij wrote: > On Fri, Jun 13, 2014 at 8:31 PM, Greg Kroah-Hartman > wrote: > > On Fri, Jun 13, 2014 at 09:25:07AM +0200, Linus Walleij wrote: > > >> But I also want to bring the device model into question: normally > >> when a mother device spawns children across different subsystems > >> we model them as MFD devices (drivers/mfd) that instantiate > >> children for the different subsystems. So you could spawn a > >> serial and a GPIO device from a USB-based hub device there. > >> > >> I do not know if that is really apropriate in this case. It seems the > >> device is first and foremost FTDI. > >> > >> But it could still spawn a child platform device for the GPIO stuff > >> so that this can live as a separate driver under drivers/gpio/gpio-ftdi.c > >> or similar. > >> > >> You could then use something like: > >> > >> struct platform_device *gdev; > > > > Ick, no, it's a USB device, do not abuse the platform_device code any > > more than it currently is (note, I HATE the platform device code, > > someday I'll delete it entirely... Well, I can dream...) > > Haha yeah :-) > > However is the MFD cell approach acceptable? Yes it is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/