Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752949AbaGGUnp (ORCPT ); Mon, 7 Jul 2014 16:43:45 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:55853 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbaGGUnn (ORCPT ); Mon, 7 Jul 2014 16:43:43 -0400 MIME-Version: 1.0 In-Reply-To: <1404667555-14675-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1404667555-14675-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Mon, 7 Jul 2014 22:43:41 +0200 X-Google-Sender-Auth: cwygXX5wIXdA8fpwWzp8Cb_HGNI Message-ID: Subject: Re: [PATCH] video: fbdev: core: fbmon.c: Cleaning up useless assignment of function parameter From: Geert Uytterhoeven To: Rickard Strandqvist Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Jingoo Han , Daniel Vetter , Laurent Pinchart , Rob Clark , David Ung , Linux Fbdev development list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 6, 2014 at 7:25 PM, Rickard Strandqvist wrote: > Remove assignment of function parameter, that has no effect outside the function > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/video/fbdev/core/fbmon.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c > index 5b0e313..71ec1ab 100644 > --- a/drivers/video/fbdev/core/fbmon.c > +++ b/drivers/video/fbdev/core/fbmon.c > @@ -1481,7 +1481,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var) > } > void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs) > { > - specs = NULL; I guess the intention was: memset(specs, 0, sizeof(struct fb_monspecs)); > } > void fb_edid_add_monspecs(unsigned char *edid, struct fb_monspecs *specs) > { Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/