Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280AbaGGUw2 (ORCPT ); Mon, 7 Jul 2014 16:52:28 -0400 Received: from mail-oa0-f54.google.com ([209.85.219.54]:46742 "EHLO mail-oa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbaGGUw1 (ORCPT ); Mon, 7 Jul 2014 16:52:27 -0400 MIME-Version: 1.0 In-Reply-To: References: <1404667555-14675-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Mon, 7 Jul 2014 22:52:26 +0200 Message-ID: Subject: Re: [PATCH] video: fbdev: core: fbmon.c: Cleaning up useless assignment of function parameter From: Rickard Strandqvist To: Geert Uytterhoeven Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Jingoo Han , Daniel Vetter , Laurent Pinchart , Rob Clark , David Ung , Linux Fbdev development list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-07-07 22:43 GMT+02:00 Geert Uytterhoeven : > On Sun, Jul 6, 2014 at 7:25 PM, Rickard Strandqvist > wrote: >> Remove assignment of function parameter, that has no effect outside the function >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist >> --- >> drivers/video/fbdev/core/fbmon.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c >> index 5b0e313..71ec1ab 100644 >> --- a/drivers/video/fbdev/core/fbmon.c >> +++ b/drivers/video/fbdev/core/fbmon.c >> @@ -1481,7 +1481,6 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var) >> } >> void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs) >> { >> - specs = NULL; > > I guess the intention was: > > memset(specs, 0, sizeof(struct fb_monspecs)); Hi Geert! Yeah, maybe. Just looks to be a little too elementary mistake..? But do you want me to change it to that? With a: if(specs) memset() maybe..? Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/