Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896AbaGHGTM (ORCPT ); Tue, 8 Jul 2014 02:19:12 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:52838 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752670AbaGHGTL (ORCPT ); Tue, 8 Jul 2014 02:19:11 -0400 MIME-Version: 1.0 In-Reply-To: <20140708051916.GB26257@dragon> References: <1404500590-21712-1-git-send-email-fabf@skynet.be> <20140707055521.GM30239@dragon> <20140708051916.GB26257@dragon> Date: Tue, 8 Jul 2014 11:49:09 +0530 Message-ID: Subject: Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO From: Sachin Kamat To: Shawn Guo Cc: Fabian Frederick , open list , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 8, 2014 at 10:49 AM, Shawn Guo wrote: > On Tue, Jul 08, 2014 at 09:18:56AM +0530, Sachin Kamat wrote: >> Hi Shawn, >> >> On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo wrote: >> > On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote: >> >> replace IS_ERR/PTR_ERR >> >> >> >> Cc: Shawn Guo >> >> Cc: Sascha Hauer >> >> Cc: linux-arm-kernel@lists.infradead.org >> >> Signed-off-by: Fabian Frederick >> > >> > Applied, thanks. >> >> >> I had sent a similar series [1] in May which you rejected. Just >> curious if something >> changed between then and now? > > The main difference is this is the second attempt from a different > person to "clean up" the code. I'm still not fond of the change, but > I'm getting tied to tell people about that, so just applied the change, > since after all it at least gives some good diffstat. > > I would prefer Fabian's patch over yours because it's really good > enough to have one patch than 5 patches in a series to do the change for > IMX platform. Doesn't really matter whose patches are in. I was just curious to know the change in logic at this point of time. Thanks for clarification. -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/