Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbaGHIVV (ORCPT ); Tue, 8 Jul 2014 04:21:21 -0400 Received: from mail-ob0-f170.google.com ([209.85.214.170]:58032 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753216AbaGHIVR (ORCPT ); Tue, 8 Jul 2014 04:21:17 -0400 MIME-Version: 1.0 In-Reply-To: <1404193516-4384-3-git-send-email-acourbot@nvidia.com> References: <1404193516-4384-1-git-send-email-acourbot@nvidia.com> <1404193516-4384-3-git-send-email-acourbot@nvidia.com> Date: Tue, 8 Jul 2014 10:21:17 +0200 Message-ID: Subject: Re: [RFC 2/3] gpio: move sysfs support to its own file From: Linus Walleij To: Alexandre Courbot Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 1, 2014 at 7:45 AM, Alexandre Courbot wrote: > sysfs support is currently entangled within the core GPIO support, while > it should relly just be a (privileged) user of the integer GPIO API. > This patch is a first step towards making the gpiolib code more readable > by splitting it into logical parts. > > Move all sysfs support to their own source file, and share static > members of gpiolib that need to be in the private gpiolib.h file. In > the future we will want to put some of them back into gpiolib.c, but this > first patch let us at least identify them. > > Signed-off-by: Alexandre Courbot Patch applied. We really need to make refactorings like this so thanks a lot. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/