Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbaGHKm4 (ORCPT ); Tue, 8 Jul 2014 06:42:56 -0400 Received: from service87.mimecast.com ([91.220.42.44]:60948 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753945AbaGHKmy convert rfc822-to-8bit (ORCPT ); Tue, 8 Jul 2014 06:42:54 -0400 Date: Tue, 8 Jul 2014 11:42:48 +0100 From: Liviu Dudau To: Bjorn Helgaas Cc: linux-pci , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Arnd Bergmann , linaro-kernel , Tanmay Inamdar , Grant Likely , Sinan Kaya , Jingoo Han , Kukjin Kim , Suravee Suthikulanit , LKML , Device Tree ML , LAKML Subject: Re: [PATCH v8 2/9] pci: Export find_pci_host_bridge() function. Message-ID: <20140708104248.GB6501@e106497-lin.cambridge.arm.com> References: <1404240214-9804-1-git-send-email-Liviu.Dudau@arm.com> <1404240214-9804-3-git-send-email-Liviu.Dudau@arm.com> <20140707232749.GA22939@google.com> MIME-Version: 1.0 In-Reply-To: <20140707232749.GA22939@google.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 08 Jul 2014 10:42:49.0300 (UTC) FILETIME=[5CB3E140:01CF9A99] X-MC-Unique: 114070811425200201 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 08, 2014 at 12:27:49AM +0100, Bjorn Helgaas wrote: > On Tue, Jul 01, 2014 at 07:43:27PM +0100, Liviu Dudau wrote: > > This is a useful function and we should make it visible outside the > > generic PCI code. Export it as a GPL symbol. > > > > Signed-off-by: Liviu Dudau > > Tested-by: Tanmay Inamdar > > --- > > drivers/pci/host-bridge.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c > > index 0e5f3c9..36c669e 100644 > > --- a/drivers/pci/host-bridge.c > > +++ b/drivers/pci/host-bridge.c > > @@ -16,12 +16,13 @@ static struct pci_bus *find_pci_root_bus(struct pci_bus *bus) > > return bus; > > } > > > > -static struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) > > +struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) > > { > > struct pci_bus *root_bus = find_pci_root_bus(bus); > > > > return to_pci_host_bridge(root_bus->bridge); > > } > > +EXPORT_SYMBOL_GPL(find_pci_host_bridge); > > There's nothing in this series that uses find_pci_host_bridge(), so > how about we just wait until we have something that needs it? > > Also, if/when we export this, I'd prefer a name that starts with "pci_" > as most of the other interfaces do. Understood. I was using the function in the other patch series that adds PCIe support to arm64 in order to provide a pci_domain_nr() implementation. But I might not need it in the end if I go ahead with separating pci_host_bridge creation from bus creation. Best regards, Liviu > > > void pci_set_host_bridge_release(struct pci_host_bridge *bridge, > > void (*release_fn)(struct pci_host_bridge *), > > -- > > 2.0.0 > > > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/