Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755302AbaGHNWY (ORCPT ); Tue, 8 Jul 2014 09:22:24 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:40333 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755275AbaGHNWU (ORCPT ); Tue, 8 Jul 2014 09:22:20 -0400 Date: Tue, 8 Jul 2014 09:22:16 -0400 From: Tejun Heo To: Mikko Perttunen Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com, pdeschrijver@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-ide@vger.kernel.org, Hans de Goede Subject: Re: [PATCH v2 6/7] ata: Add support for the Tegra124 SATA controller Message-ID: <20140708132216.GA4979@htj.dyndns.org> References: <1403101406-15439-1-git-send-email-mperttunen@nvidia.com> <1403101406-15439-7-git-send-email-mperttunen@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403101406-15439-7-git-send-email-mperttunen@nvidia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (cc'ing Hans) Hans, can you please review this patch? On Wed, Jun 18, 2014 at 05:23:25PM +0300, Mikko Perttunen wrote: > +#define SATA_CONFIGURATION_0 0x180 > +#define SATA_CONFIGURATION_EN_FPCI BIT(0) Let's just indent uniformly. The new line should give enough visual hint on grouping. > +struct tegra_ahci_priv { > + struct platform_device *pdev; > + void __iomem *sata_regs; > + struct reset_control *sata_rst; > + struct reset_control *sata_oob_rst; > + struct reset_control *sata_cold_rst; > + struct clk *sata_clk; > + struct clk *sata_oob_clk; > + struct clk *cml1_clk; > + struct clk *plle_clk; > + struct regulator_bulk_data supplies[5]; > + struct phy *padctl_phy; > +}; And please indent the declared fields uniformly too. Except for the above nitpicks, generally looks good to me but let's wait for Hans' review. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/