Date: Tue, 8 Jul 2014 18:07:22 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        kernel-janitors@vger.kernel.org, gulsah.1004@gmail.com,
        gregkh@linuxfoundation.org, linville@tuxdriver.com,
        paulmck@linux.vnet.ibm.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8192ee: Correct bitmask in comparsion
Message-ID: <20140708150722.GP25880@mwanda>
References: <1404827699-7295-1-git-send-email-andrey.krieger.utkin@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1404827699-7295-1-git-send-email-andrey.krieger.utkin@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Jul 08, 2014 at 04:54:59PM +0300, Andrey Utkin wrote:
> The issue is discovered by static checker. The proposed change (0x000c0
> -> 0x000c) is likely correct because:
> 1. 16-bit `map` holds value coming from struct
> ieee80211_vht_mcs_info.tx_mcs_map, which is described so: "TX MCS map 2
> bits for each stream, total 8 streams". The changed code refers to case
> of 2 TX streams, and 0x000c mask filters two bits related to the second
> stream. Some codelines below 0x0003 mask is used to test first stream.
> 2. Mask 0x000c is used 3 more times in that place.
> 3. Specifying 5 digits of hex value is uncommon, especially while working
> with `u16` variable. So likely the trailing zero is a typo.

This changelog is perfect.  Thanks.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/