Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753495AbaGHPTs (ORCPT ); Tue, 8 Jul 2014 11:19:48 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:39679 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbaGHPTr (ORCPT ); Tue, 8 Jul 2014 11:19:47 -0400 MIME-Version: 1.0 In-Reply-To: References: <1404823639-6496-1-git-send-email-mmarek@suse.cz> Date: Tue, 8 Jul 2014 17:19:46 +0200 Message-ID: Subject: Re: [PATCH] firmware: Create directories for external firmware From: Ronald To: Michal Marek Cc: Torsten Kaiser , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-07-08 17:18 GMT+02:00 Ronald : > My full name is 'Ronald Uitermark'. > > I will try this patch tonight. > > > 2014-07-08 14:47 GMT+02:00 Michal Marek : > >> Commit 5180d5f4 ("firmware: Simplify directory creation") broke >> including firmware specified in CONFIG_EXTRA_FIRMWARE: >> >> MK_FW firmware/amd-ucode/microcode_amd.bin.gen.S >> /bin/sh: firmware/amd-ucode/microcode_amd.bin.gen.S: No such file or >> directory >> ... >> firmware/Makefile:185: recipe for target >> 'firmware/amd-ucode/microcode_amd.bin.gen.S' failed >> >> It works with O= builds, because the directory is created by >> Makefile.build. Create the directory in firmware/Makefile in non-O >> builds. >> >> Reported-by: Ronald >> Reported-by: Torsten Kaiser >> Signed-off-by: Michal Marek >> --- >> >> Can you try this patch? >> >> Ronald, can you tell me your full name for the Reported-by: line? >> >> Thanks. >> --- >> >> firmware/Makefile | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/firmware/Makefile b/firmware/Makefile >> index 5747417..0862d34 100644 >> --- a/firmware/Makefile >> +++ b/firmware/Makefile >> @@ -219,6 +219,12 @@ $(obj)/%.fw: $(obj)/%.H16 $(ihex2fw_dep) >> obj-y += $(patsubst %,%.gen.o, >> $(fw-external-y)) >> obj-$(CONFIG_FIRMWARE_IN_KERNEL) += $(patsubst %,%.gen.o, >> $(fw-shipped-y)) >> >> +ifeq ($(KBUILD_SRC),) >> +# Makefile.build only creates subdirectories for O= builds, but external >> +# firmware might live outside the kernel source tree >> +_dummy := $(foreach d,$(addprefix $(obj)/,$(dir $(fw-external-y))), >> $(shell [ -d $(d) ] || mkdir -p $(d))) >> +endif >> + >> # Remove .S files and binaries created from ihex >> # (during 'make clean' .config isn't included so they're all in >> $(fw-shipped-)) >> targets := $(fw-shipped-) $(patsubst $(obj)/%,%, \ >> -- >> 1.8.4.5 >> > (resend for flat text mode, sorry for the dupe which included top posting) My full name is 'Ronald Uitermark'. I will try this patch tonight. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/