Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754452AbaGHPda (ORCPT ); Tue, 8 Jul 2014 11:33:30 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37237 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753794AbaGHPd0 convert rfc822-to-8bit (ORCPT ); Tue, 8 Jul 2014 11:33:26 -0400 MIME-Version: 1.0 In-Reply-To: References: <1404833138-8244-1-git-send-email-prabhakar.csengg@gmail.com> From: Prabhakar Lad Date: Tue, 8 Jul 2014 16:32:52 +0100 Message-ID: Subject: Re: [PATCH] cpufreq: Makefile: fix compilation for davinci platform To: Viresh Kumar Cc: Linux Kernel Mailing List , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Sekhar Nori , dlos Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 8, 2014 at 4:29 PM, Viresh Kumar wrote: > On 8 July 2014 20:55, Lad, Prabhakar wrote: >> From patch with commt-id:8a7b1227e303d7e927214ee0f260041aef44bb58 >> "cpufreq: davinci: move cpufreq driver to drivers/cpufreq" >> this added dependancy only for CONFIG_ARCH_DAVINCI_DA850 where as >> davinci_cpufreq_init() call is used by all davinci platform. >> >> This patch fixes following build error: >> >> arch/arm/mach-davinci/built-in.o: In function `davinci_init_late': >> :(.init.text+0x928): undefined reference to `davinci_cpufreq_init' >> make: *** [vmlinux] Error 1 >> >> Signed-off-by: Lad, Prabhakar >> --- >> drivers/cpufreq/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile >> index 738c8b7..db6d9a2 100644 >> --- a/drivers/cpufreq/Makefile >> +++ b/drivers/cpufreq/Makefile >> @@ -49,7 +49,7 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ) += arm_big_little.o >> # LITTLE drivers, so that it is probed last. >> obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o >> >> -obj-$(CONFIG_ARCH_DAVINCI_DA850) += davinci-cpufreq.o >> +obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o >> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o >> obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += exynos-cpufreq.o >> obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o > > It took one year and 5 kernel releases to catch this again? > For a long time I was been working on DA850 itself, so couldn’t notice it :(. > Acked-by: Viresh Kumar Thanks! Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/