Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754080AbaGHPmE (ORCPT ); Tue, 8 Jul 2014 11:42:04 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:64060 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752108AbaGHPmC (ORCPT ); Tue, 8 Jul 2014 11:42:02 -0400 MIME-Version: 1.0 In-Reply-To: References: <1404828488-7649-1-git-send-email-andrey.krieger.utkin@gmail.com> From: Prabhakar Lad Date: Tue, 8 Jul 2014 16:41:30 +0100 Message-ID: Subject: Re: [PATCH] [media] davinci-vpfe: Fix retcode check To: Andrey Utkin Cc: Levente Kurusa , "linux-kernel@vger.kernel.org" , OSUOSL Drivers , Linux Media , Greg Kroah-Hartman , Mauro Carvalho Chehab , Josh Triplett , Archana Kumari , Lisa Nguyen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrey, Thanks for the patch! On Tue, Jul 8, 2014 at 3:58 PM, Andrey Utkin wrote: > 2014-07-08 17:32 GMT+03:00 Levente Kurusa : >> Hmm, while it is true that get_ipipe_mode returns an int, but >> the consequent call to regw_ip takes an u32 as its second >> argument. Did it cause a build warning for you? (Can't really >> check since I don't have ARM cross compilers close-by) >> If not, then: > > Cannot say for sure would compiler complain. > I also haven't really checked it, and unfortunately even haven't > succeeded to make a config that would build that code. But i believe > that warning is still better than misbehaviour. > It wont cause any compile warning. Applied for v3.17 Thanks, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/