Message-ID: <1404837211.932.18.camel@joe-AO725>
Subject: Re: [PATCH v2 2/4] Staging: rts5208: Replace custom macro with
 print_hex_dump_bytes
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Fabio Falzoi <fabio.falzoi84@gmail.com>,
        micky <micky_ching@realsil.com.cn>, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org, wei_wang@realsil.com.cn,
        linux-kernel@vger.kernel.org
Date: Tue, 08 Jul 2014 09:33:31 -0700
In-Reply-To: <20140708084517.GG25880@mwanda>
References: <1404717004-29540-1-git-send-email-fabio.falzoi84@gmail.com>
	 <1404717004-29540-3-git-send-email-fabio.falzoi84@gmail.com>
	 <53BB538C.1080605@realsil.com.cn>
	 <CACar8LkcvOc5dEkFp2pCMmtiO=e7_zOK-2NYhGz6AmQYu2bh-g@mail.gmail.com>
	 <20140708084517.GG25880@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-07-08 at 11:45 +0300, Dan Carpenter wrote:
> On Tue, Jul 08, 2014 at 08:23:02AM +0200, Fabio Falzoi wrote:
> I'm gonna fix it, thanks.
> And leave out the semi-colon as well.

another way to do this is:

static void rtsx_hex_dump(void *buf, size_t len)
{
#if DEBUG
	print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, buf, len);
#endif
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/