Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755187AbaGHR2K (ORCPT ); Tue, 8 Jul 2014 13:28:10 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30021 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753405AbaGHR2G (ORCPT ); Tue, 8 Jul 2014 13:28:06 -0400 Date: Tue, 8 Jul 2014 11:08:12 -0400 From: Konrad Rzeszutek Wilk To: Stefano Stabellini Cc: Rickard Strandqvist , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Jingoo Han , Daniel Vetter , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter Message-ID: <20140708150812.GC2863@laptop.dumpdata.com> References: <1404667640-14855-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 07, 2014 at 11:20:39AM +0100, Stefano Stabellini wrote: > On Sun, 6 Jul 2014, Rickard Strandqvist wrote: > > Remove assignment of function parameter, that has no effect outside the function > > > > This was found using a static code analysis program called cppcheck > > > > Signed-off-by: Rickard Strandqvist > > Acked-by: Stefano Stabellini and Reviewed-by: Konrad Rzeszutek Wilk > > > > drivers/video/fbdev/xen-fbfront.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c > > index 901014b..e1207a1 100644 > > --- a/drivers/video/fbdev/xen-fbfront.c > > +++ b/drivers/video/fbdev/xen-fbfront.c > > @@ -222,7 +222,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green, > > red = CNVT_TOHW(red, info->var.red.length); > > green = CNVT_TOHW(green, info->var.green.length); > > blue = CNVT_TOHW(blue, info->var.blue.length); > > - transp = CNVT_TOHW(transp, info->var.transp.length); > > #undef CNVT_TOHW > > > > v = (red << info->var.red.offset) | > > -- > > 1.7.10.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/