Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754897AbaGHS2l (ORCPT ); Tue, 8 Jul 2014 14:28:41 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53232 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753405AbaGHS2k (ORCPT ); Tue, 8 Jul 2014 14:28:40 -0400 Date: Tue, 08 Jul 2014 11:28:38 -0700 (PDT) Message-Id: <20140708.112838.2087453949565741801.davem@davemloft.net> To: zoltan.kiss@citrix.com Cc: steffen.klassert@secunet.com, minipli@googlemail.com, dborkman@redhat.com, tgraf@suug.ch, joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH net-next 1/3 v4] pktgen: Fill the payload optionally with a pattern From: David Miller In-Reply-To: <1404330855-24546-2-git-send-email-zoltan.kiss@citrix.com> References: <1404330855-24546-1-git-send-email-zoltan.kiss@citrix.com> <1404330855-24546-2-git-send-email-zoltan.kiss@citrix.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Jul 2014 11:28:39 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zoltan Kiss Date: Wed, 2 Jul 2014 20:54:13 +0100 > @@ -1129,11 +1133,13 @@ static ssize_t pktgen_if_write(struct file *file, > i += len; > > if (node_possible(value)) { > + int j; > pkt_dev->node = value; > sprintf(pg_result, "OK: node=%d", pkt_dev->node); > - if (pkt_dev->page) { > - put_page(pkt_dev->page); > - pkt_dev->page = NULL; > + for (j = 0; j < MAX_SKB_FRAGS; ++j) > + if (pkt_dev->pages[j]) { > + put_page(pkt_dev->pages[j]); > + pkt_dev->pages[j] = NULL; > } > } I'm scratching my head with the bracing created here, and it's because the indentation is wrong: for () /* <-- no openning curly brace */ if () { x; y; } /* <-- thus, wrong indentation */ Please resubmit this series with this fixed and #3 adjusted as per the feedback you've received. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/