Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754280AbaGHUle (ORCPT ); Tue, 8 Jul 2014 16:41:34 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:52780 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753857AbaGHUlc (ORCPT ); Tue, 8 Jul 2014 16:41:32 -0400 Date: Tue, 8 Jul 2014 13:41:24 -0700 From: "Paul E. McKenney" To: Joe Perches Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, sbw@mit.edu Subject: Re: [PATCH tip/core/rcu 2/3] rcu: Add designated reviewers for RCU Message-ID: <20140708204124.GW4603@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20140707224146.GA9118@linux.vnet.ibm.com> <1404772924-9423-1-git-send-email-paulmck@linux.vnet.ibm.com> <1404772924-9423-2-git-send-email-paulmck@linux.vnet.ibm.com> <20140708080908.GN19379@twins.programming.kicks-ass.net> <1404842784.932.22.camel@joe-AO725> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404842784.932.22.camel@joe-AO725> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14070820-0928-0000-0000-000003369FC7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 08, 2014 at 11:06:24AM -0700, Joe Perches wrote: > On Tue, 2014-07-08 at 10:09 +0200, Peter Zijlstra wrote: > > On Mon, Jul 07, 2014 at 03:42:03PM -0700, Paul E. McKenney wrote: > > > MAINTAINERS | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 1814075c0e74..92f2bf91eec1 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -7405,6 +7405,9 @@ F: kernel/rcu/torture.c > > > > > > RCUTORTURE TEST FRAMEWORK > > > M: "Paul E. McKenney" > > > +R: Steven Rostedt > > > +R: Mathieu Desnoyers > > > +R: Lai Jiangshan > > > L: linux-kernel@vger.kernel.org > > > S: Supported > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > > > > OK,.. so if we're going to do this can we talk about the syntax here. > > > > I would like to also use this for SCHED and PERF, but since both are > > rather big I would like to be able to subdivide things. Now I could of > > course go create many MAINTAINER sections, but that feels artificial. > > > > So I would like to be able to write: > > > > SCHEDULER: > > ... > > R: Steven Rostedt (kernel/sched/rt.c) > > R: Juri Lelli (kernel/sched/deadline.c) > > > > or something like that. And here I've already done concessions in that > > the above is machine readable. Ideally I'd be able to say things like: > > 'for sched and numa related things' add 'rik and mel'. > > > > Hmm, maybe we can look at the patch subject tag like: sched/numa or > > sched/rt or sched/deadline etc.. instead of the files touched. > > I think it's best to use separate sections. > > The parsing logic in get_maintainers is already ugly enough. OK, here is a basic change. Hey, I figure that if you weren't desperately in need of entertainment, you would not have asked me to hack a perl script! Thanx, Paul ------------------------------------------------------------------------ scripts: Teach get_maintainer.pl about the new "R:" tag We can now designate reviewers in the MAINTAINERS file with the new "R:" tag, so this commit teaches get_maintainers.pl to add their email addresses. Reported-by: Joe Perches Signed-off-by: Paul E. McKenney diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index 41987885bd31..03785ce7b5b6 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -536,7 +536,7 @@ sub range_has_maintainer { if ($line =~ m/^(\C):\s*(.*)/) { my $type = $1; my $value = $2; - if ($type eq 'M') { + if ($type eq 'M' || $type eq 'R') { return 1; } } @@ -1047,7 +1047,7 @@ sub add_categories { } } } - } elsif ($ptype eq "M") { + } elsif ($ptype eq "M" || $ptype eq "R") { my ($name, $address) = parse_email($pvalue); if ($name eq "") { if ($i > 0) { @@ -1062,7 +1062,11 @@ sub add_categories { } if ($email_maintainer) { my $role = get_maintainer_role($i); - push_email_addresses($pvalue, $role); + if ($ptype eq "M") { + push_email_addresses($pvalue, $role); + } else { + push_email_addresses($pvalue, "designated reviewer"); + } } } elsif ($ptype eq "T") { push(@scm, $pvalue); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/