Date: Tue, 8 Jul 2014 13:45:30 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Li, Aubrey" <aubrey.li@linux.intel.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] GPIO button wth wakeup attribute is supposed to wake the
 system up
Message-ID: <20140708204530.GA23908@core.coreip.homeip.net>
References: <53A2340D.9030503@linux.intel.com>
 <13019301.98tkdHyOVf@vostro.rjw.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <13019301.98tkdHyOVf@vostro.rjw.lan>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Jul 08, 2014 at 10:52:52PM +0200, Rafael J. Wysocki wrote:
> On Thursday, June 19, 2014 08:51:25 AM Li, Aubrey wrote:
> > When the wakeup attribute is set, the GPIO button is capable of
> > waking up the system from sleep states, including the "freeze"
> > sleep state.  For that to work, its driver needs to pass the
> > IRQF_NO_SUSPEND flag to devm_request_any_context_irq(), or the
> > interrupt will be disabled by suspend_device_irqs() and the
> > system won't be woken up by it from the "freeze" sleep state.
> > 
> > The suspend_device_irqs() routine is a workaround for drivers
> > that mishandle interrupts triggered when the devices handled
> > by them are suspended, so it is safe to use IRQF_NO_SUSPEND in
> > all drivers that don't have that problem.
> > 
> > The affected/tested machines include Dell Venue 11 Pro and Asus T100TA.
> > 
> > Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
> > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> OK
> 
> Due to the lack of response (ie. no objections) and because the issue
> addressed by this patch is real, I'm queuing it up as a PM-related fix
> for 3.17.

Please do not. The response is till the same: board code should make sure
that enable_irq_wake() does the right thing and keeps interrupts enabled.

It is wrong to patch drivers for this.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/