Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753643AbaGHWsI (ORCPT ); Tue, 8 Jul 2014 18:48:08 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:36283 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753143AbaGHWsE (ORCPT ); Tue, 8 Jul 2014 18:48:04 -0400 MIME-Version: 1.0 In-Reply-To: References: <1402866165-17408-1-git-send-email-minipli@googlemail.com> Date: Wed, 9 Jul 2014 08:48:02 +1000 Message-ID: Subject: Re: [PATCH] agp: remove read/write stubs From: Dave Airlie To: Mathias Krause Cc: David Airlie , "linux-kernel@vger.kernel.org" , Alexander Viro Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2 July 2014 16:15, Mathias Krause wrote: > On 15 June 2014 23:02, Mathias Krause wrote: >> The VFS layer handles those in the very same way, if unset. No need for >> additional stubs. >> >> Signed-off-by: Mathias Krause >> Cc: Alexander Viro >> --- >> drivers/char/agp/frontend.c | 15 --------------- >> 1 file changed, 15 deletions(-) >> >> diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c >> index b29703324e..09f17eb734 100644 >> --- a/drivers/char/agp/frontend.c >> +++ b/drivers/char/agp/frontend.c >> @@ -710,19 +710,6 @@ static int agp_open(struct inode *inode, struct file *file) >> return 0; >> } >> >> - >> -static ssize_t agp_read(struct file *file, char __user *buf, >> - size_t count, loff_t * ppos) >> -{ >> - return -EINVAL; >> -} >> - >> -static ssize_t agp_write(struct file *file, const char __user *buf, >> - size_t count, loff_t * ppos) >> -{ >> - return -EINVAL; >> -} >> - >> static int agpioc_info_wrap(struct agp_file_private *priv, void __user *arg) >> { >> struct agp_info userinfo; >> @@ -1047,8 +1034,6 @@ static const struct file_operations agp_fops = >> { >> .owner = THIS_MODULE, >> .llseek = no_llseek, >> - .read = agp_read, >> - .write = agp_write, >> .unlocked_ioctl = agp_ioctl, >> #ifdef CONFIG_COMPAT >> .compat_ioctl = compat_agp_ioctl, >> -- >> 1.7.10.4 >> > > Ping. Any objections, comments? David? Are you sure VFS handles this the same way? can you point me where it checks ->read and returns -EINVAL, I'm probably just missing it in my quick look over fs/read_write.c Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/