Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753887AbaGHWsz (ORCPT ); Tue, 8 Jul 2014 18:48:55 -0400 Received: from service87.mimecast.com ([91.220.42.44]:48654 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753731AbaGHWsw convert rfc822-to-8bit (ORCPT ); Tue, 8 Jul 2014 18:48:52 -0400 Date: Tue, 8 Jul 2014 23:48:47 +0100 From: Liviu Dudau To: Bjorn Helgaas Cc: linux-pci , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Arnd Bergmann , linaro-kernel , Tanmay Inamdar , Grant Likely , Sinan Kaya , Jingoo Han , Kukjin Kim , Suravee Suthikulanit , LKML , Device Tree ML , LAKML Subject: Re: [PATCH v8 6/9] pci: Introduce a domain number for pci_host_bridge. Message-ID: <20140708224847.GC4980@e106497-lin.cambridge.arm.com> References: <1404240214-9804-1-git-send-email-Liviu.Dudau@arm.com> <1404240214-9804-7-git-send-email-Liviu.Dudau@arm.com> <20140708005954.GC22939@google.com> <20140708104655.GC6501@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 08 Jul 2014 22:48:48.0569 (UTC) FILETIME=[C80CDA90:01CF9AFE] X-MC-Unique: 114070823485000201 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 08, 2014 at 07:41:50PM +0100, Bjorn Helgaas wrote: > On Tue, Jul 8, 2014 at 4:46 AM, Liviu Dudau wrote: > > On Tue, Jul 08, 2014 at 01:59:54AM +0100, Bjorn Helgaas wrote: > > >> I wonder if it would help to make a weak pci_domain_nr() function that > >> returns "bridge->domain_nr". Then each arch could individually drop its > >> pci_domain_nr() definition as it was converted, e.g., something like this: > >> > >> - Convert every arch pci_domain_nr() from a #define to a non-inline > >> function > >> - Add bridge.domain_nr, initialized from pci_domain_nr() > >> - Add a weak generic pci_domain_nr() that returns bridge.domain_nr > >> - Add a way to create a host bridge in a specified domain, so we can > >> initialize bridge.domain_nr without using pci_domain_nr() > >> - Convert each arch to use the new creation mechanism and drop its > >> pci_domain_nr() implementation > > > > I will try to propose a patch implementing this. > > I think this is more of an extra credit, cleanup sort of thing. I > don't think it advances your primary goal of (I think) getting arm64 > PCI support in. So my advice is to not worry about unifying domain > handling until later. Getting arm64 supported *is* my main goal. But like you have stated in your review of v7, you wanted to see another architecture converted as a guarantee of "genericity" (for lack of a better word) for my patches. The one architecture I've set my eyes on is microblaze, and that one uses pci_scan_root_bus() rather than pci_create_root_bus() so I don't have any opportunity to pass the domain number or any additional info (like the sysdata pointer that we were talking about) to the pci_host_bridge structure unless I do this cleanup. Best regards, Liviu > > Bjorn > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/