Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753320AbaGIAfq (ORCPT ); Tue, 8 Jul 2014 20:35:46 -0400 Received: from ozlabs.org ([103.22.144.67]:58152 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751064AbaGIAfl (ORCPT ); Tue, 8 Jul 2014 20:35:41 -0400 From: Rusty Russell To: Christoph Hellwig , Hannes Reinecke Cc: James Bottomley , Christoph Hellwig , Ewan Milne , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] scsi: use 64-bit value for 'max_luns' In-Reply-To: <20140625122856.GA3221@infradead.org> References: <1401785937-43581-1-git-send-email-hare@suse.de> <1401785937-43581-6-git-send-email-hare@suse.de> <20140625122856.GA3221@infradead.org> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 09 Jul 2014 09:30:19 +0930 Message-ID: <87a98j765o.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig writes: > On Tue, Jun 03, 2014 at 10:58:56AM +0200, Hannes Reinecke wrote: >> Now that we're using 64-bit LUNs internally we need to increase >> the size of max_luns to 64 bits, too. >> >> Signed-off-by: Hannes Reinecke >> Reviewed-by: Christoph Hellwig >> Reviewed-by: Ewan Milne > > I just noticed that this has changes to the module param code. > These should be split into a separate patch and be ACKed by the modules > maintainer. I'd still love to take the change through the SCSI tree to > be able to get this into 3.17 easily. > > moduleparam changes below: > >> diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h >> index 204a677..21e2ba6 100644 >> --- a/include/linux/moduleparam.h >> +++ b/include/linux/moduleparam.h >> @@ -381,6 +381,11 @@ extern int param_set_ulong(const char *val, const struct kernel_param *kp); >> extern int param_get_ulong(char *buffer, const struct kernel_param *kp); >> #define param_check_ulong(name, p) __param_check(name, p, unsigned long) >> >> +extern struct kernel_param_ops param_ops_ullong; >> +extern int param_set_ullong(const char *val, const struct kernel_param *kp); >> +extern int param_get_ullong(char *buffer, const struct kernel_param *kp); >> +#define param_check_ullong(name, p) __param_check(name, p, unsigned long long) >> + >> extern struct kernel_param_ops param_ops_charp; >> extern int param_set_charp(const char *val, const struct kernel_param *kp); >> extern int param_get_charp(char *buffer, const struct kernel_param *kp); > >> diff --git a/kernel/params.c b/kernel/params.c >> index b00142e..2b2a9dd 100644 >> --- a/kernel/params.c >> +++ b/kernel/params.c >> @@ -253,6 +253,7 @@ STANDARD_PARAM_DEF(int, int, "%i", kstrtoint); >> STANDARD_PARAM_DEF(uint, unsigned int, "%u", kstrtouint); >> STANDARD_PARAM_DEF(long, long, "%li", kstrtol); >> STANDARD_PARAM_DEF(ulong, unsigned long, "%lu", kstrtoul); >> +STANDARD_PARAM_DEF(ullong, unsigned long long, "%llu", kstrtoull); Thanks Christoph! Acked-by: Rusty Russell Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/