Message-ID: <1404870498.932.79.camel@joe-AO725>
Subject: Re: [PATCH v3 2/4] Staging: rts5208: Replace custom macro with
 print_hex_dump_bytes
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Fabio Falzoi <fabio.falzoi84@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, dan.carpenter@oracle.com,
        wei_wang@realsil.com.cn, micky_ching@realsil.com.cn
Date: Tue, 08 Jul 2014 18:48:18 -0700
In-Reply-To: <20140708234529.GA25645@kroah.com>
References: <1404855512-5864-1-git-send-email-fabio.falzoi84@gmail.com>
	 <1404855512-5864-3-git-send-email-fabio.falzoi84@gmail.com>
	 <20140708234529.GA25645@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-07-08 at 16:45 -0700, Greg KH wrote:
> On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote:
> > Use print_hex_dump_bytes to have memory properly dumped only when
> > DEBUG is defined.
[]
> > diff --git a/drivers/staging/rts5208/trace.h b/drivers/staging/rts5208/trace.h
[]
> > @@ -82,12 +82,11 @@ static inline char *filename(char *path)
[]
> > +static inline void rtsx_hex_dump(const void *buf, size_t len)
> > +{
> > +#ifdef DEBUG
> > +	print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, buf, len);
> >  #endif
> > +}
> 
> What a mess.  What's wrong with just using the %*ph modifier in
> dev_dbg() like other drivers do?

Dunno.
Is it ever desired to emit more than 64 bytes of buf?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/