Date: Tue, 8 Jul 2014 19:13:12 -0700
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org, namhyung@kernel.org,
        acme@infradead.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/9] perf, tools: Automatically look for event file name
 for cpu v3
Message-ID: <20140709021312.GA25311@us.ibm.com>
References: <1402700580-26939-1-git-send-email-andi@firstfloor.org>
 <1402700580-26939-5-git-send-email-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1402700580-26939-5-git-send-email-andi@firstfloor.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

Andi Kleen [andi@firstfloor.org] wrote:

| +static const char *json_default_name(void)
| +{
| +	char *cache;
| +	char *idstr = get_cpu_str();
| +	char *res = NULL;
| +	char *home = NULL;
| +	char *emap;
| +
| +	emap = getenv("EVENTMAP");
| +	if (emap) {
| +		if (access(emap, R_OK) == 0)
| +			return emap;
| +		if (asprintf(&idstr, "%s-core", emap) < 0)
| +			return NULL;
| +	}

Hi Andi,

Couple of questions/comments about EVENTMAP and the "core" suffix.

Is EVENTMAP a new environment variable ? If specific to PERF, should
we prefix it with "PERF_" to avoid collision?

Would all/many architectures need this "-core" suffix or is that Intel
specific ?

Is the intent that architectures that don't need this should simply
never set EVENTMAP variable ?

| +
| +	cache = getenv("XDG_CACHE_HOME");
| +	if (!cache) {
| +		home = getenv("HOME");
| +		if (!home || asprintf(&cache, "%s/.cache", home) < 0)
| +			goto out;
| +	}

As with XDG_CACHE_HOME in perf-download.txt, can you please add a note
about usage of EVENTMAP in the man page.

| +	if (cache && idstr)
| +		res = mkpath("%s/pmu-events/%s.json",
| +			     cache,
| +			     idstr);
| +	if (home)
| +		free(cache);
| +out:
| +	free(idstr);
| +	return res;
| +}
| +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/