Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754509AbaGIDul (ORCPT ); Tue, 8 Jul 2014 23:50:41 -0400 Received: from mail-oa0-f53.google.com ([209.85.219.53]:38681 "EHLO mail-oa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752171AbaGIDuj convert rfc822-to-8bit (ORCPT ); Tue, 8 Jul 2014 23:50:39 -0400 MIME-Version: 1.0 In-Reply-To: <53AA151E.9090701@suse.de> References: <1403633766-25796-1-git-send-email-bjorn.andersson@sonymobile.com> <53AA151E.9090701@suse.de> Date: Tue, 8 Jul 2014 20:50:38 -0700 Message-ID: Subject: Re: [PATCH v2] pinctrl: msm: Add msm8960 definitions From: Bjorn Andersson To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: Bjorn Andersson , Linus Walleij , Andy Gross , "devicetree@vger.kernel.org" , linux-arm-msm , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 24, 2014 at 5:17 PM, Andreas Färber wrote: > Am 24.06.2014 20:16, schrieb Bjorn Andersson: >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt >> new file mode 100644 >> index 0000000..6e79eea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt > [...] >> +Example: >> + >> + msmgpio: pinctrl@800000 { >> + compatible = "qcom,msm8960-pinctrl"; >> + reg = <0x800000 0x4000>; >> + >> + gpio-controller; >> + #gpio-cells = <2>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + interrupts = <0 32 0x4>; > > This line seems space-indented while surrounding ones are tab-indented. > Thanks, not only is it incorrectly indented, it's also a bad example as it's the wrong IRQ for msm8960... >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&debug_uart>; >> + >> + debug_uart: debug_uart { > > While at it, might debug-uart be a better node name? That seems the > predominant convention and distinguishes from the label. > You're right and reference design does not use gsbi8 as uart, so I'll update it. Thanks for the review. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/