Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755036AbaGIHuv (ORCPT ); Wed, 9 Jul 2014 03:50:51 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:40546 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754498AbaGIHup convert rfc822-to-8bit (ORCPT ); Wed, 9 Jul 2014 03:50:45 -0400 MIME-Version: 1.0 In-Reply-To: <53B94DC6.7070308@gmail.com> References: <1404457379-4193-1-git-send-email-varkab@cdac.in> <53B94DC6.7070308@gmail.com> Date: Wed, 9 Jul 2014 09:50:45 +0200 Message-ID: Subject: Re: [PATCH v2] drivers/gpio/gpio-sch311x: check return value of gpiochip_remove() From: Linus Walleij To: Varka Bhadram Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List , Varka Bhadram Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 6, 2014 at 3:23 PM, Varka Bhadram wrote: > On Sunday 06 July 2014 02:52 PM, Alexandre Courbot wrote: >> On Fri, Jul 4, 2014 at 4:02 PM, Varka Bhadram >> wrote: >>> >>> This patch eliminates the following warning >>> >>> drivers/gpio/gpio-sch311x.c: In function ‘sch311x_gpio_probe’: >>> drivers/gpio/gpio-sch311x.c:286:18: warning: ignoring return value of >>> ‘gpiochip_remove’, declared with attribute warn_unused_result >> >> gpiochip_remove() is to have its return value set to void in another >> patch, so I'm not sure we need this one in the meantime? > > > I also saw that patch from abdoulaye berthe . > > If that is accepted its good. If not this may require. Yeah I'll go remove that. Just working out the patch mechanics right now, we'll probably remove all return value checks in v3.17 and then delete the code in gpiolib in late v3.17 cycle or the next merge window. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/