Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755138AbaGIH7G (ORCPT ); Wed, 9 Jul 2014 03:59:06 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:59392 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754947AbaGIH7D (ORCPT ); Wed, 9 Jul 2014 03:59:03 -0400 MIME-Version: 1.0 In-Reply-To: <1404782785-1824-2-git-send-email-bjorn.andersson@sonymobile.com> References: <1404782785-1824-1-git-send-email-bjorn.andersson@sonymobile.com> <1404782785-1824-2-git-send-email-bjorn.andersson@sonymobile.com> Date: Wed, 9 Jul 2014 09:59:02 +0200 Message-ID: Subject: Re: [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status From: Linus Walleij To: Bjorn Andersson Cc: Lee Jones , Stephen Boyd , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 8, 2014 at 3:26 AM, Bjorn Andersson wrote: > Most status bits, e.g. for GPIO and MPP input, is retrieved by reading > the interrupt status registers, so this needs to be exposed to clients. > > Signed-off-by: Bjorn Andersson Hm do you mean you read the input *values* from the interrupt status registers? What madness in that case.... :-) Anyway, since the driver is based on regmap, can't the children just get a regmap * somehow and then just go read the same register instead of having to add a special function for it? When I look at it it seems like it's doing regmap strangely or something, like it's one write then one read operation to get the register(s) and isn't that all supposed to be hidden behind regmap so you don't need the local lock chip->pm_irq_lock? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/