Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802AbaGIIkA (ORCPT ); Wed, 9 Jul 2014 04:40:00 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53483 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbaGIIj4 (ORCPT ); Wed, 9 Jul 2014 04:39:56 -0400 Date: Wed, 9 Jul 2014 01:39:54 -0700 From: Christoph Hellwig To: "K. Y. Srinivasan" Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, ohering@suse.com, jbottomley@parallels.com, jasowang@redhat.com, apw@canonical.com, linux-scsi@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host Message-ID: <20140709083954.GA6012@infradead.org> References: <1404866789-26910-1-git-send-email-kys@microsoft.com> <1404866812-26950-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404866812-26950-1-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 08, 2014 at 05:46:45PM -0700, K. Y. Srinivasan wrote: > + * In Hyper-V, each port/path/target maps to 1 scsi host adapter. Does it still? The STORVSC_FC_MAX_TARGETS define suggests otherwise. > - .cmd_per_lun = 1, > + .cmd_per_lun = 255, This looks like an unrelated change. > + /* max # of devices per target */ > + host->max_lun = STORVSC_FC_MAX_LUNS_PER_TARGET; > + /* max # of targets per channel */ > + host->max_id = STORVSC_FC_MAX_TARGETS; > + /* max # of channels */ > + host->max_channel = STORVSC_FC_MAX_CHANNELS - 1; I don't think these comments add any value.. Also any reason you use off by one defines for max_channel, but not the others? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/